Make __precompile__(false) non-fatal for cachecompile / requires
#28402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
compiler:precompilation
ararslan
reviewed
Aug 2, 2018
stdlib/Pkg/src/API.jl
Outdated
| push!(needs_to_be_precompiled, pkg.name) | ||
| end | ||
| if stale | ||
| printpkgstyle(ctx, :Precompiling, pkg) |
There was a problem hiding this comment.
pkg is a PkgId but this function expects the third argument to be a string, which is why the tests are failing.
And make it equivalent to `exit(125)` Fixes #28384
|
This is the last fix blocking the next RC. |
now possible, since __precompile__ is the default, and it automatically handles __precompile__(false)
Keno
force-pushed
the
jn/teh/fix_noprecompile
branch
from
0d75353
to
91cf8b6
Compare
|
Fixed and rebased. |
ngam
reviewed
Dec 23, 2021
| end | ||
| @test Base.compilecache(Base.PkgId("Baz")) == Base.PrecompilableError() # due to __precompile__(false) | ||
| @eval using Baz | ||
| @test Base.invokelatest(Baz.baz) == 1 |
There was a problem hiding this comment.
Something in 1.7.0 is breaking this on some machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #28386